Add enumerator attributes #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like GitHub Actions macos-13 machines may have also updated some SDKs because there are now the same CI failures there. |
|
Merging now since it fixes Goblint MacOS CI which otherwise fails for everything. |
|
This also appears on Linux in |
sim642
added a commit
to sim642/opam-repository
that referenced
this pull request
Nov 25, 2024
CHANGES: * Add enumerator attributes (goblint/cil#172). * Generate 32bit and 64bit `Machdep` if possible (goblint/cil#173).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In opam-repository CI goblint.2.4.0 saw MacOS failures with
This seems to be https://github.com/alexey-lysiuk/macos-sdk/blob/69ddec41e6224afebd5f19bb24764305ac3e828a/MacOSX14.5.sdk/usr/include/sys/qos.h#L130-L143, where attributes are after individual enum items (enumerators).
It is valid syntax for GCC attributes: https://gcc.gnu.org/onlinedocs/gcc/Enumerator-Attributes.html.