Fix first in location synthesizing #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
michael-schwarz
approved these changes
Feb 10, 2024
|
I ran sv-benchmarks with our validation and this caused the confirmation rate to drop:
I don't exactly know why that is, but these fixed locations are definitely a correction for collaborating with other tools. These benchmarks were with Goblint self-validation, so it wasn't bothered at all by the invalid locations: it generated them and also validated them at the same (invalid) locations. |
sim642
added a commit
to sim642/opam-repository
that referenced
this pull request
Jul 30, 2024
CHANGES: * Add `Return` statement expression location (goblint/cil#167). * Add `availability` attribute support (goblint/cil#168, goblint/cil#171). * Remove unused `Libmaincil` module (goblint/cil#165). * Fix some synthetic locations (goblint/cil#166, goblint/cil#167).
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: * Add `Return` statement expression location (goblint/cil#167). * Add `availability` attribute support (goblint/cil#168, goblint/cil#171). * Remove unused `Libmaincil` module (goblint/cil#165). * Fix some synthetic locations (goblint/cil#166, goblint/cil#167).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
c/weaver/chl-collitem-subst.wvr.cproblem in goblint/analyzer#1356.Because the logic of making locations synthetic is "Change all stmt and instr locs to synthetic, except the first one." and the
firstflag indicates whether the current statement is first, the logic should be flipped. That is, the first location should not be made synthetic.It's surprising that this complete logic flip didn't reveal itself from the very beginning of synthetic locations. This could be the reason we couldn't verify so many of our own witnesses even.