Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for webhook notifications containing html #2674

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

manuelsc
Copy link
Collaborator

@manuelsc manuelsc commented Nov 7, 2023

🤖 Generated by Copilot at 2f506be

Improved the notification text for validator withdrawals and refactored the currency formatting functions in the utils package. Extracted common logic for formatting currency values as strings into separate functions in utils/format.go.

@LuccaBitfly LuccaBitfly self-assigned this Nov 13, 2023
Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck, pls look at the one remark I have

utils/format.go Show resolved Hide resolved
@manuelsc manuelsc merged commit 33e5522 into gobitfly:master Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants