(BIDS-2535) cleanup method names replacement #2623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D13ce
suggested changes
Oct 23, 2023
handlers/eth1Block.go
Outdated
| txs = append(txs, types.Eth1BlockPageTransaction{ | ||
| Hash: fmt.Sprintf("%#x", tx.Hash), | ||
| HashFormatted: utils.FormatAddressWithLimits(tx.Hash, "", false, "tx", 15, 18, true), | ||
| From: fmt.Sprintf("%#x", tx.From), | ||
| FromFormatted: utils.FormatAddressWithLimits(tx.From, names[string(tx.From)], false, "address", 15, 20, true), | ||
| To: fmt.Sprintf("%#x", tx.To), | ||
| ToFormatted: utils.FormatAddressWithLimits(tx.To, names[string(tx.To)], names[string(tx.To)] == "Contract Creation" || len(method) > 0, "address", 15, 20, true), | ||
| ToFormatted: utils.FormatAddressWithLimits(tx.To, names[string(tx.To)], tx.GetInvokesContract(), "address", 15, 20, true), |
There was a problem hiding this comment.
This causes the contract symbol to disappear for "Contract Creation".
Before:
Now:
Is this intended? Personally I don't think it is as the contract symbol is shown in the same case here:
eth2-beaconchain-explorer/db/bigtable_eth1.go
Line 2150 in 929fbe8
The same applies to
There was a problem hiding this comment.
You are correct, this was not intended. A lot has changed with the new approach, I think it should be correct now
remoterami
force-pushed
the
BIDS-2535/cleanup_method_names_replacement
branch
2 times, most recently
from
0d5b7d6 to
4642450
Compare
remoterami
force-pushed
the
BIDS-2535/cleanup_method_names_replacement
branch
from
4642450 to
27e9233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2618
🤖 Generated by Copilot at 929fbe8
This pull request enhances the support for contract creation and invocation transactions in the eth2-beaconchain-explorer. It improves the data handling, display, and formatting of these transactions in the
bigtable_eth1,handlers, andrpcpackages, and adds a new fieldinvokes_contractto theTransactionmessage in theeth1.protofile.