BEDS 1065/apps christmas miracle #1239
Open
+164
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying beaconchain with
|
| Latest commit: |
53bc77d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1cf7c52e.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-1065-apps-christmas-mir.beaconchain.pages.dev |
LuccaBitfly
commented
Jan 9, 2025
There was a problem hiding this comment.
if the changes here don't fit the intended usage for this file please lmk
- adds efficiency, balances and rewards fields See: BEDS-1065
See: BEDS-1065
See: BEDS-1065
See: BEDS-1065
See: BEDS-1065
LuccaBitfly
force-pushed
the
BEDS-1065/apps-christmas-miracle
branch
from
df5ec40 to
53bc77d
Compare
remoterami
requested changes
Jan 9, 2025
Comment on lines
-832
to
+859
| func (d *DataAccessService) internal_getElClAPR(ctx context.Context, dashboardId t.VDBId, groupId int64, hours int) (elIncome decimal.Decimal, elAPR float64, clIncome decimal.Decimal, clAPR float64, err error) { | ||
| func (d *DataAccessService) getElClAPR(ctx context.Context, dashboardId t.VDBId, groupId int64, hours int) (elIncome decimal.Decimal, elAPR float64, clIncome decimal.Decimal, clAPR float64, err error) { |
There was a problem hiding this comment.
That function could probably also be moved to vdb_helpers.go, it's used a few times in different locations 🙏
Comment on lines
+828
to
+831
| if totalIdealAttestationRewards > 0 { | ||
| attestationEfficiency.Float64 = decimal.NewFromInt(totalAttestationRewards).Div(decimal.NewFromInt(totalIdealAttestationRewards)).InexactFloat64() | ||
| attestationEfficiency.Valid = true | ||
| } |
There was a problem hiding this comment.
This was calculated above already, see ret.AttestationEfficiency
Comment on lines
+842
to
+854
| rpOperatorInfo, err := d.getValidatorDashboardRpOperatorInfo(ctx, dashboardId) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| validatorMapping, err := d.services.GetCurrentValidatorMapping() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| balances, err := d.calculateValidatorDashboardBalance(ctx, rpOperatorInfo, validators, validatorMapping, protocolModes) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ret.Balances = balances |
There was a problem hiding this comment.
check: This would factor in the protocolModes for the new balances field, but the rest of the function does not yet use the parameter. I'm not 100% certain which other fields would also be affected, but apr might be a candidate.
- If there are any, I would prefer to not return "mixed" data as that could be confusing. Rather either apply the calculation to all relevant fields, or (temporarily) apply it to none (hardcoding
protocolModes.RocketPooltofalse) - If there are none (which might actually be the case, could be that the parameter is just a leftover from when we were briefly planning to add RP stats to the group summaries or something), the comment about it at the top of the method should be removed / clarified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds efficiency, balances and rewards field to validator dashboard group summary.
Rule-of-thumb performance estimates: