Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BEDS-1100) API: Incorporate dashboard archival status into notification endpoints #1233

Merged

Conversation

remoterami
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2025

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12864ad
Status: ✅  Deploy successful!
Preview URL: https://72bff15c.beaconchain.pages.dev
Branch Preview URL: https://beds-1100-api-notifications.beaconchain.pages.dev

View logs

@remoterami remoterami changed the title (BEDS-1100) API: add vdb archived check to notifications middleware (BEDS-1100) API: Incorporate dashboard archival status into notification endpoints Jan 6, 2025
backend/pkg/api/router.go Outdated Show resolved Hide resolved
backend/pkg/api/router.go Show resolved Hide resolved
@LuccaBitfly
Copy link
Contributor

LuccaBitfly commented Jan 7, 2025

Also if you're not adding integration tests now, pls create medium prio ticket for adding them.

@remoterami
Copy link
Contributor Author

Also if you're not adding integration tests now, pls create medium prio ticket for adding them.

I think that should be covered by 579 already

backend/pkg/api/router.go Outdated Show resolved Hide resolved
backend/pkg/api/handlers/middlewares.go Show resolved Hide resolved
Copy link
Contributor

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@remoterami remoterami merged commit a1d5ae3 into staging Jan 9, 2025
4 checks passed
@remoterami remoterami deleted the BEDS-1100/api-notifications-middleware-filter-archived branch January 9, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants