(BEDS-875) Add rewards chart history based on premium perks

[remoterami]

No description provided.

[cloudflare-workers-and-pages]

Deploying beaconchain with    Cloudflare Pages

Latest commit:	c6d5fa4
Status:	✅  Deploy successful!
Preview URL:	https://70c9eb59.beaconchain.pages.dev
Branch Preview URL:	https://beds-875-rewards-chart.beaconchain.pages.dev

View logs

[sasha-bitfly]

What is the int value that we pass is invalid?

Should we have a function that checks the valid number

func (d ChartType) IsValid() bool {
    return d >= ChartDefault && d <= ChartRewards
}

and maybe a function that stringify for debugging and logging purposes?

func (d ChartType) String() string {
    switch d {
    case ChartDefault:
        return "Default"
    case ChartRewards:
        return "Rewards"
    default:
        return "Unknown"
    }
}

[remoterami]

What is the int value that we pass is invalid?

This should be covered here already:

beaconchain/backend/pkg/api/enums/enums.go

Lines 15 to 17 in 2ca36e5

	func IsInvalidEnum(e Enum) bool {
	return e.Int() == -1
	}

and maybe a function that stringify for debugging and logging purposes?

It's meant as an internal type only, thought it's cleaner than passing strings or numbers. It doesn't depend on user params and isn't logged anywhere, so I think that's not needed.

[sasha-bitfly]

@remoterami Ideally to cover the changes with tests. Unit tests are nice, but api tests can be fine.

[LuccaBitfly]

lgtm

[remoterami]

@remoterami Ideally to cover the changes with tests. Unit tests are nice, but api tests can be fine.

I've added some tests and did some refactoring. Could probably further solidify and generalize the testing setup, but that depends on our coverage goals and I didn't want to over-engineer for now. Open to suggestions though