Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#443: Add realloc array function #472

Merged

Conversation

m3g4d1v3r
Copy link
Contributor

This pull request adds the realloc_array wrapper to the code base (it's inspired on alloc_array's implementation).
This is a Work In Progress. Please let me know if any fixes should be made.

Best regards.
m3g4d1v3r

@m3g4d1v3r
Copy link
Contributor Author

Issue #443

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (71dc567) to head (b942dc6).
Report is 2 commits behind head on latest.

Files with missing lines Patch % Lines
src/memory.c 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #472      +/-   ##
==========================================
- Coverage   90.60%   90.58%   -0.02%     
==========================================
  Files          47       47              
  Lines        4385     4388       +3     
  Branches      587      588       +1     
==========================================
+ Hits         3973     3975       +2     
  Misses        279      279              
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goatshriek goatshriek self-assigned this Oct 25, 2024
Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for putting this together! Just a few minor cleanups noted here and I believe it will be ready to merge.

src/memory.c Outdated Show resolved Hide resolved
src/element.c Outdated Show resolved Hide resolved
@m3g4d1v3r m3g4d1v3r force-pushed the 443-add-realloc-array-function branch from 8908af6 to 80539a2 Compare October 29, 2024 14:14
@m3g4d1v3r m3g4d1v3r force-pushed the 443-add-realloc-array-function branch from 80539a2 to b942dc6 Compare October 30, 2024 08:45
@goatshriek goatshriek merged commit b638f77 into goatshriek:latest Nov 2, 2024
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants