-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an alloc_array
function
#458
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #458 +/- ##
==========================================
+ Coverage 90.35% 90.54% +0.19%
==========================================
Files 47 47
Lines 4374 4379 +5
Branches 586 587 +1
==========================================
+ Hits 3952 3965 +13
+ Misses 287 280 -7
+ Partials 135 134 -1 ☔ View full report in Codecov by Sentry. |
Both the failed tests were in calls to EDIT: Scratch that, forgot to free the entry I created in the test. My bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Just a few cleanup items: make sure that you aren't using tabs anywhere, and move the large struct into the new test instead of making it a fixture structure.
This PR solves #440 and adds an
alloc_array
function. All uses ofalloc_mem
which can be replaced withalloc_array
have been replaced withalloc_array
. A test forstumpless_copy_entry
has been added as well.