Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update benchmark documentation to match code #452

Closed
wants to merge 1 commit into from

Conversation

Brijeshthummar02
Copy link

issue #444

@goatshriek goatshriek self-assigned this Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (72f40f9) to head (6447dfb).
Report is 6 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest     #452   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files          47       47           
  Lines        4373     4373           
  Branches      585      585           
=======================================
  Hits         3957     3957           
  Misses        281      281           
  Partials      135      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the actual test in test/function/element.cpp, this change does not completely bring the two into matching.

Thank you for refactoring with the fixture function! Be sure that you update the actual test as well as the docs with the refactored code, to ensure that it compiles and works correctly.

docs/benchmark.md Show resolved Hide resolved
@Brijeshthummar02 Brijeshthummar02 deleted the Updated branch October 16, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants