added prival to string function #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c8b8bb1.
uFarad
changed the title
|
Note that the continuous integration tests cannot run until the merge conflicts are resolved. |
|
It successfully compiles and passes tests locally. It should be good to go. |
|
Thanks very much for getting this together! You can disregard the codecov upload failures, those are due to a separate issue I am working on addressing. I will do a more thorough review of the change in the next few days. |
goatshriek
requested changes
Apr 17, 2024
This reverts commit 5e117cd.
|
Thank you once again for working through this! My apologies for the many confusing CI failures - you had the misfortune of committing during a time of codecov breakage and also discovering a bug in the header checking tool. |
|
It was my pleasure. Thank you for creating an amazing project that is friendly to those new to OSS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function to convert the prival integer to a string in response to issue #245
@mk722 did great work on this previously, but seems to be inactive now after a bout with COVID. I hope they had a speedy recovery.
I took over this change from where they left off. Please let me know if anything needs to be changed or if I am not following proper procedures. I hope to contribute to more open source projects like this one in the future.