Private folder doc #390
Merged
Private folder doc #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatshriek
requested changes
Nov 9, 2023
added 2 commits
November 10, 2023 14:44
… and fix uncorrent AC-safety documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #390 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 44 44
Lines 3776 3776
Branches 497 497
=======================================
Hits 3466 3466
Misses 216 216
Partials 94 94 ☔ View full report in Codecov by Sentry. |
|
This will be good to go once the other |
|
My bad i thought it was only the old one, but i removed other since tags now. |
goatshriek
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #371 (comment)
Documented the first 5 functions in include/private/entry.h
I am fairly new to checking for asynchronous safety so it would be nice if someone can review and give feedback.