Bug 1856695 - Improve how we handle MIDI port creation

goastian · Nov 2, 2023 · 4190f58 · 4190f58
1 parent 97ef27d
commit 4190f58
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 12 deletions.
diff --git a/dom/midi/MIDIInput.h b/dom/midi/MIDIInput.h
@@ -21,10 +21,11 @@ class MIDIPortInfo;
  */
 class MIDIInput final : public MIDIPort {
  public:
-static RefPtr<MIDIInput> Create(nsPIDOMWindowInner* aWindow,
+  static RefPtr<MIDIInput> Create(nsPIDOMWindowInner* aWindow,
                                   MIDIAccess* aMIDIAccessParent,
                                   const MIDIPortInfo& aPortInfo,
                                   const bool aSysexEnabled);
+  ~MIDIInput() = default;
 
   JSObject* WrapObject(JSContext* aCx,
                        JS::Handle<JSObject*> aGivenProto) override;
@@ -50,4 +51,4 @@ static RefPtr<MIDIInput> Create(nsPIDOMWindowInner* aWindow,
 
 }  // namespace mozilla::dom
 
-#endif  // mozilla_dom_MIDIInput_h
+#endif  // mozilla_dom_MIDIInput_h
diff --git a/dom/midi/MIDIPort.cpp b/dom/midi/MIDIPort.cpp
@@ -36,12 +36,11 @@ NS_INTERFACE_MAP_END_INHERITING(DOMEventTargetHelper)
 NS_IMPL_ADDREF_INHERITED(MIDIPort, DOMEventTargetHelper)
 NS_IMPL_RELEASE_INHERITED(MIDIPort, DOMEventTargetHelper)
 
-MIDIPort::MIDIPort(nsPIDOMWindowInner* aWindow, MIDIAccess* aMIDIAccessParent)
+MIDIPort::MIDIPort(nsPIDOMWindowInner* aWindow)
     : DOMEventTargetHelper(aWindow),
-      mMIDIAccessParent(aMIDIAccessParent),
+      mMIDIAccessParent(nullptr),
       mKeepAlive(false) {
   MOZ_ASSERT(aWindow);
-  MOZ_ASSERT(aMIDIAccessParent);
 
   Document* aDoc = GetOwner()->GetExtantDoc();
   if (aDoc) {
@@ -62,8 +61,19 @@ MIDIPort::~MIDIPort() {
   }
 }
 
-bool MIDIPort::Initialize(const MIDIPortInfo& aPortInfo, bool aSysexEnabled) {
-  nsIURI* uri = GetDocumentIfCurrent()->GetDocumentURI();
+bool MIDIPort::Initialize(const MIDIPortInfo& aPortInfo, bool aSysexEnabled,
+                          MIDIAccess* aMIDIAccessParent) {
+  MOZ_ASSERT(aMIDIAccessParent);
+  nsCOMPtr<Document> document = GetDocumentIfCurrent();
+  if (!document) {
+    return false;
+  }
+
+  nsCOMPtr<nsIURI> uri = document->GetDocumentURI();
+  if (!uri) {
+    return false;
+  }
+
   nsAutoCString origin;
   nsresult rv = nsContentUtils::GetASCIIOrigin(uri, origin);
   if (NS_FAILED(rv)) {
@@ -90,6 +100,8 @@ bool MIDIPort::Initialize(const MIDIPortInfo& aPortInfo, bool aSysexEnabled) {
                              aSysexEnabled)) {
     return false;
   }
+
+  mMIDIAccessParent = aMIDIAccessParent;
   mPortHolder.Init(port.forget());
   LOG("MIDIPort::Initialize (%s, %s)",
       NS_ConvertUTF16toUTF8(Port()->Name()).get(),

diff --git a/dom/midi/MIDIPort.h b/dom/midi/MIDIPort.h
@@ -38,8 +38,9 @@ class MIDIPort : public DOMEventTargetHelper,
   NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_INHERITED(MIDIPort,
                                                          DOMEventTargetHelper)
  protected:
-  MIDIPort(nsPIDOMWindowInner* aWindow, MIDIAccess* aMIDIAccessParent);
-  bool Initialize(const MIDIPortInfo& aPortInfo, bool aSysexEnabled);
+explicit MIDIPort(nsPIDOMWindowInner* aWindow);
+  bool Initialize(const MIDIPortInfo& aPortInfo, bool aSysexEnabled,
+                  MIDIAccess* aMIDIAccessParent);
   virtual ~MIDIPort();
 
  public:

diff --git a/netwerk/protocol/http/nsHttpChannel.cpp b/netwerk/protocol/http/nsHttpChannel.cpp
@@ -3969,13 +3969,11 @@ nsHttpChannel::OnCacheEntryCheck(nsICacheEntry* entry, uint32_t* aResult) {
     rv = GenerateCacheKey(mPostID, cacheKey);
     MOZ_ASSERT(NS_SUCCEEDED(rv));
 
-    auto redirectedCachekeys = mRedirectedCachekeys.Lock();
+   auto redirectedCachekeys = mRedirectedCachekeys.Lock();
     auto& ref = redirectedCachekeys.ref();
     if (!ref) {
       ref = MakeUnique<nsTArray<nsCString>>();
     } else if (ref->Contains(cacheKey)) {
-      mRedirectedCachekeys = MakeUnique<nsTArray<nsCString>>();
-    } else if (mRedirectedCachekeys->Contains(cacheKey)) {
       doValidation = true;
     }