Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.0+ Union and Intersection type support on SelfValueVisitor #504

Conversation

samsonasik
Copy link
Contributor

Closes #503

@samsonasik
Copy link
Contributor Author

@lisachenko could you review this? Thank you.

@lisachenko
Copy link
Member

PS. The more I look on the SelfValueVisitor/SelfValueTransformer classes - the more I think that they do very strange and incorrect job, which I would like to completely rewrite to enable pretty-printing and to switch to AST-only transformation.

FYI: I'm now in the process of slow refactoring of entire AST/transformation subsystem, so expect significant changes in this part soon )

Could you please check if current PR works with the latest master branch or not (try to rebase and check locally please)? I've some bad feeling that there is a regression issue from my recent refactoring of goaop/parser-reflection that renders 'self' now with '\self' (

@samsonasik
Copy link
Contributor Author

Using dev-master seems working ok

Screenshot 2024-05-06 at 05 41 33

@samsonasik
Copy link
Contributor Author

@lisachenko Ready to merge 👍

@samsonasik
Copy link
Contributor Author

@lisachenko Ready to merge 👍

@samsonasik
Copy link
Contributor Author

Also handled self usage in anonymous class

@samsonasik
Copy link
Contributor Author

@lisachenko Ready to merge 👍

@lisachenko lisachenko added this to the 4.0.0 milestone May 7, 2024
@lisachenko lisachenko merged commit e20f450 into goaop:bug/functional-weaving-complex-type May 7, 2024
5 of 6 checks passed
@lisachenko
Copy link
Member

Squashed and merged into the main branch. Thanks!

@samsonasik samsonasik deleted the bug/functional-weaving-complex-type branch May 7, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants