Fix a few issues #48
Merged
Fix a few issues #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
raphael
commented
Nov 28, 2024
raphael
commented
- Make sure that adding a dispatch return event to a node stream creates the stream if needed. This could cause jobs that are added right on startup to fail to be dispatched.
- Fix potential panic in cleanup goroutine when the pending jobs map contains nil values
- Make sure to close all maps when closing the node.
- Properly log event information when discarding stale ack events.
- More consistent logging
* Make sure that adding a dispatch return event to a node stream creates the stream if needed. This could cause jobs that are added right on startup to fail to be dispatched. * Fix potential panic in cleanup goroutine when the pending jobs map contains nil values * Make sure to close all maps when closing the node. * Properly log event information when discarding stale ack events. * More consistent logging
* Ensure stale node streams are gced * Make close and shutdown code cleaner * Cleanup all maps properly on node close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.