Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Reimplement cache with badger #362

Merged
merged 1 commit into from
May 4, 2024
Merged

✨ Reimplement cache with badger #362

merged 1 commit into from
May 4, 2024

Conversation

tosone
Copy link
Contributor

@tosone tosone commented May 2, 2024

No description provided.

@tosone tosone added the unit test Add unit test label May 2, 2024
@tosone tosone added this to the Release v1.3.0 milestone May 2, 2024
@tosone tosone self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 39.62264% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 25.11%. Comparing base (6c643f6) to head (13141b8).

Files Patch % Lines
pkg/modules/cacher/badger/badger.go 36.84% 24 Missing ⚠️
pkg/configs/default.go 0.00% 14 Missing and 9 partials ⚠️
pkg/dal/badger/badger.go 55.00% 7 Missing and 2 partials ⚠️
pkg/modules/cacher/cacher.go 33.33% 2 Missing ⚠️
pkg/modules/cacher/inmemory/inmemory.go 80.00% 2 Missing ⚠️
pkg/modules/locker/locker.go 33.33% 2 Missing ⚠️
pkg/dal/dao/mocks/workq.go 0.00% 1 Missing ⚠️
pkg/modules/cacher/redis/redis.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   25.52%   25.11%   -0.42%     
==========================================
  Files         275      269       -6     
  Lines       19365    18833     -532     
==========================================
- Hits         4942     4729     -213     
+ Misses      13955    13663     -292     
+ Partials      468      441      -27     
Flag Coverage Δ
unit-test-mysql 25.08% <39.62%> (-0.44%) ⬇️
unit-test-postgresql 25.11% <39.62%> (-0.42%) ⬇️
unit-test-sqlite3 25.11% <39.62%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tosone tosone force-pushed the tosone-3 branch 6 times, most recently from 88faf39 to eaabf0b Compare May 4, 2024 04:55
@tosone tosone changed the title ✨ Add test case for database cache ✨ Reimplement cache with badger May 4, 2024
@tosone tosone enabled auto-merge May 4, 2024 05:41
@tosone tosone added this pull request to the merge queue May 4, 2024
Merged via the queue into main with commit 04b3c3f May 4, 2024
14 checks passed
@tosone tosone deleted the tosone-3 branch May 4, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit test Add unit test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant