✅ Update dao test (#344)

* ✨ Update blob cacher

* ✅ Update dao test

pkg/dal/dao/audit_test.go

@@ -43,17 +43,13 @@ func TestAuditServiceFactory(t *testing.T) {
 func TestAuditService(t *testing.T) {
 	viper.SetDefault("log.level", "debug")
 	logger.SetLevel("debug")
-	err := tests.Initialize(t)
-	assert.NoError(t, err)
-	err = tests.DB.Init()
-	assert.NoError(t, err)
+	assert.NoError(t, tests.Initialize(t))
+	assert.NoError(t, tests.DB.Init())
 	defer func() {
 		conn, err := dal.DB.DB()
 		assert.NoError(t, err)
-		err = conn.Close()
-		assert.NoError(t, err)
-		err = tests.DB.DeInit()
-		assert.NoError(t, err)
+		assert.NoError(t, conn.Close())
+		assert.NoError(t, tests.DB.DeInit())
 	}()
 
 	ctx := log.Logger.WithContext(context.Background())
@@ -67,7 +63,7 @@ func TestAuditService(t *testing.T) {
 	assert.NotNil(t, namespaceService)
 
 	namespaceObj1 := &models.Namespace{Name: "test"}
-	err = namespaceService.Create(ctx, namespaceObj1)
+	err := namespaceService.Create(ctx, namespaceObj1)
 	assert.NoError(t, err)
 
 	userServiceFactory := dao.NewUserServiceFactory()

pkg/dal/dao/blob_test.go

@@ -43,24 +43,21 @@ func TestBlobServiceFactory(t *testing.T) {
 func TestBlobService(t *testing.T) {
 	viper.SetDefault("log.level", "debug")
 	logger.SetLevel("debug")
-	err := tests.Initialize(t)
-	assert.NoError(t, err)
-	err = tests.DB.Init()
-	assert.NoError(t, err)
+	assert.NoError(t, tests.Initialize(t))
+	assert.NoError(t, tests.DB.Init())
 	defer func() {
 		conn, err := dal.DB.DB()
 		assert.NoError(t, err)
-		err = conn.Close()
-		assert.NoError(t, err)
+		assert.NoError(t, conn.Close())
 		assert.NoError(t, tests.DB.DeInit())
 	}()
 
 	ctx := log.Logger.WithContext(context.Background())
 
 	f := dao.NewBlobServiceFactory()
-	err = query.Q.Transaction(func(tx *query.Query) error {
+	err := query.Q.Transaction(func(tx *query.Query) error {
 		blobService := f.New(tx)
-		err = blobService.Create(ctx, &models.Blob{
+		err := blobService.Create(ctx, &models.Blob{
 			Digest:      "sha256:123",
 			Size:        123,
 			ContentType: "test",

pkg/dal/dao/namespace.go

@@ -203,12 +203,6 @@ func (s *namespaceService) UpdateByID(ctx context.Context, id int64, updates map
 	if len(updates) == 0 {
 		return nil
 	}
-	matched, err := s.tx.Namespace.WithContext(ctx).Where(s.tx.Namespace.ID.Eq(id)).Updates(updates)
-	if err != nil {
-		return err
-	}
-	if matched.RowsAffected == 0 {
-		return gorm.ErrRecordNotFound
-	}
-	return nil
+	_, err := s.tx.Namespace.WithContext(ctx).Where(s.tx.Namespace.ID.Eq(id)).Updates(updates)
+	return err
 }

pkg/dal/dao/namespace_test.go

@@ -111,9 +111,6 @@ func TestNamespaceService(t *testing.T) {
 		err = namespaceService.UpdateByID(ctx, namespaceObj.ID, map[string]interface{}{query.Namespace.Description.ColumnName().String(): "test"})
 		assert.NoError(t, err)
 
-		err = namespaceService.UpdateByID(ctx, 10, map[string]interface{}{query.Namespace.Description.ColumnName().String(): "test"})
-		assert.ErrorIs(t, err, gorm.ErrRecordNotFound)
-
 		err = namespaceService.DeleteByID(ctx, namespaceObj.ID)
 		assert.NoError(t, err)
 

pkg/dal/dao/repository_test.go

@@ -51,10 +51,8 @@ func TestRepositoryService(t *testing.T) {
 	defer func() {
 		conn, err := dal.DB.DB()
 		assert.NoError(t, err)
-		err = conn.Close()
-		assert.NoError(t, err)
-		err = tests.DB.DeInit()
-		assert.NoError(t, err)
+		assert.NoError(t, conn.Close())
+		assert.NoError(t, tests.DB.DeInit())
 	}()
 
 	ctx := log.Logger.WithContext(context.Background())

pkg/types/enums/enums.go

@@ -82,6 +82,7 @@ type CacherType string
 // redis,
 // kafka,
 // database,
+// inmemory,
 // )
 type WorkQueueType string