Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: added tests to the account domain #993

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Conversation

fmartingr
Copy link
Member

@fmartingr fmartingr commented Oct 12, 2024

Several people has been telling me that the Remember Me check is not working, so I have added a few tests to ensure it's working.

So far I haven't seen any issues, if any of you landing here experience some weird behaviour please open an issue so I can investiagate further.

Refactored the code a bit and added a testutil.GetValidAccount() to be used for authenticated tests and prevent discrepancies between manually set up test code (more notably the logged in user requiring an ID).

@fmartingr fmartingr self-assigned this Oct 12, 2024
@fmartingr fmartingr changed the title tests: Added tests to the account domain tests: added tests to the account domain Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.74%. Comparing base (8c35a6b) to head (7a606dc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/domains/accounts.go 87.50% 2 Missing ⚠️
internal/http/routes/api/v1/auth.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
- Coverage   35.33%   34.74%   -0.60%     
==========================================
  Files          61       61              
  Lines        4078     5322    +1244     
==========================================
+ Hits         1441     1849     +408     
- Misses       2414     3249     +835     
- Partials      223      224       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr fmartingr merged commit 4a58ef0 into master Nov 1, 2024
14 of 15 checks passed
@fmartingr fmartingr deleted the chore/auth-tests branch November 1, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant