Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure bookmark files are correctly downloaded before deleting current ones #683

Merged
merged 37 commits into from
Aug 20, 2023
Merged

fix: Ensure bookmark files are correctly downloaded before deleting current ones #683

merged 37 commits into from
Aug 20, 2023

Commits on Jul 28, 2023

  1. generate ebook get dstPath

    @Monirzadeh
    Monirzadeh committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7aa37d2 View commit details
    Browse the repository at this point in the history

  2. Archive and ebook can recover if download faild

    @Monirzadeh
    Monirzadeh committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    91937b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. recover thumb if download faild

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    c12e3f2 View commit details
    Browse the repository at this point in the history

  2. thumb image create just if image processing is sucssesful

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    379a3ba View commit details
    Browse the repository at this point in the history

  3. create epub in tmp if it sucssesful copy to destination

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    42afd23 View commit details
    Browse the repository at this point in the history

  4. archive file create in tmp if it successful move to destination

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    624a746 View commit details
    Browse the repository at this point in the history

  5. move to destination as function

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    2ec8e5e View commit details
    Browse the repository at this point in the history

  6. update ebook download api and remove .epub from file name

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    44b9a13 View commit details
    Browse the repository at this point in the history

  7. report faild item to user

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    622ff9d View commit details
    Browse the repository at this point in the history

  8. not show dialog if error not happen

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    bf31c3b View commit details
    Browse the repository at this point in the history

  9. update thumbnail based on last status of bookmark fix go-shiori#524

    @Monirzadeh
    Monirzadeh committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    658c80f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. better warning massage 

    Co-authored-by: Felipe Martin <[email protected]>
    @Monirzadeh @fmartingr
    Monirzadeh and fmartingr authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    87b6861 View commit details
    Browse the repository at this point in the history

  2. tmpFile without .epub

    @Monirzadeh
    Monirzadeh committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    c54da26 View commit details
    Browse the repository at this point in the history

  3. MoveToDestination change to MoveFileToDestination

    @Monirzadeh
    Monirzadeh committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    0a752e1 View commit details
    Browse the repository at this point in the history

  4. return .epub

    @Monirzadeh
    Monirzadeh committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    89c04d6 View commit details
    Browse the repository at this point in the history

  5. log if downloadBookImage return error

    @Monirzadeh
    Monirzadeh committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    2b489ea View commit details
    Browse the repository at this point in the history

  6. fix bug remove imgPath just if download last image be unsuccessful

    @Monirzadeh
    Monirzadeh committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    3588119 View commit details
    Browse the repository at this point in the history

  7. update old unit test

    @Monirzadeh
    Monirzadeh committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    81703cb View commit details
    Browse the repository at this point in the history

  8. add processing.go unit test

    @Monirzadeh
    Monirzadeh committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    e56ef8f View commit details
    Browse the repository at this point in the history

  9. small massage for report failded item to the user

    @Monirzadeh
    Monirzadeh committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    947eefa View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. add some more unit test and samplefile

    @Monirzadeh
    Monirzadeh committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    757599f View commit details
    Browse the repository at this point in the history

  2. use sample image in unit test

    @Monirzadeh
    Monirzadeh committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d33384a View commit details
    Browse the repository at this point in the history

  3. use local sample file and unit test not need internet connection anymore

    @Monirzadeh
    Monirzadeh committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d1a6412 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. update error to user and log that too

    @Monirzadeh
    Monirzadeh committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    a44caad View commit details
    Browse the repository at this point in the history

  2. add more comment

    @Monirzadeh
    Monirzadeh committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    612c439 View commit details
    Browse the repository at this point in the history

  3. update comment

    @Monirzadeh
    Monirzadeh committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    9a42103 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. change variable name parentDir to dstDir

    @Monirzadeh
    Monirzadeh committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    55bb071 View commit details
    Browse the repository at this point in the history

  2. more simpler error handling

    @Monirzadeh
    Monirzadeh committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3da6206 View commit details
    Browse the repository at this point in the history

  3. remove unneeded defer

    @Monirzadeh
    Monirzadeh committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    1630092 View commit details
    Browse the repository at this point in the history

  4. remvoe unneeded epubWriter.Close()

    @Monirzadeh
    Monirzadeh committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    afba6ff View commit details
    Browse the repository at this point in the history

  5. more readable unit test in processing

    @Monirzadeh
    Monirzadeh committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    17f984d View commit details
    Browse the repository at this point in the history

  6. more readable unit test for ebooks

    @Monirzadeh
    Monirzadeh committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    bf95321 View commit details
    Browse the repository at this point in the history

  7. delete all defer os.RemoveAll from unit tests

    @Monirzadeh
    Monirzadeh committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    7f26e3f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into cache-recovery

    @Monirzadeh
    Monirzadeh committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9341e4d View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Better comment 

    Co-authored-by: Felipe Martin <[email protected]>
    @Monirzadeh @fmartingr
    Monirzadeh and fmartingr authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    cdf6fab View commit details
    Browse the repository at this point in the history

  2. Better Error output 

    Co-authored-by: Felipe Martin <[email protected]>
    @Monirzadeh @fmartingr
    Monirzadeh and fmartingr authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    587340b View commit details
    Browse the repository at this point in the history

  3. fix err.String() method

    @Monirzadeh
    Monirzadeh committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    3003099 View commit details
    Browse the repository at this point in the history