replication,cmd: improve flavor handling #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there is an good way to make it auto detect the flavor this would be even better |
lance6716
reviewed
Nov 14, 2024
| serverVersion := b.c.GetServerVersion() | ||
| if b.cfg.Flavor != MariaDBFlavor && | ||
| strings.Contains(b.c.GetServerVersion(), "MariaDB") { | ||
| b.cfg.Logger.Errorf("misconfigured flavor (%s) for server %s", |
There was a problem hiding this comment.
And I think we can add comment to explain why this is only a log not a failure to caller, like "MariaDB still sends binlog events in a compatible way although some functionalities are lost, so we just log the problem"
There was a problem hiding this comment.
I've added a code comment. Or did you want to put this in the message instead?
dveeden
force-pushed
the
flavor_handling
branch
from
641d0b6 to
9d2038e
Compare
For `go-mysqlbinlog` and `go-canal`: return an error for invalid flavors. For `go-mysqlbinlog`: log a non-critical error if the server version has "MariaDB" in it but the flavor isn't set to "mariadb".
dveeden
force-pushed
the
flavor_handling
branch
from
9d2038e to
d02805d
Compare
lance6716
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: close #944
For
go-mysqlbinlogandgo-canal: return an error for invalid flavors.For
go-mysqlbinlog: log a non-critical error if the server version has "MariaDB" in it but the flavor isn't set to "mariadb".