dump: use --source-data based on version

[dveeden]

Use mysqldump --source-data ... instead of mysqldump --master-data ... based on the version of mysqldump.

Related

• Support MySQL 8.4.0 #866

[dveeden]

This might not work if mariadb-dump is used instead of mysqldump... however it would then likely fail to extract the version and an empty version string would still cause --master-data to be called.

In the future MariaDB might remove mysqldump...

dvaneeden@dve-carbon:~$ ./opt/mysql/11.2.2/bin/mariadb-dump --help | head -1
./opt/mysql/11.2.2/bin/mariadb-dump from 11.2.2-MariaDB, client 10.19 for linux-systemd (x86_64)
dvaneeden@dve-carbon:~$ ./opt/mysql/11.2.2/bin/mysqldump --help | head -1
./opt/mysql/11.2.2/bin/mysqldump: Deprecated program name. It will be removed in a future release, use '/home/dvaneeden/opt/mysql/11.2.2/bin/mariadb-dump' instead
./opt/mysql/11.2.2/bin/mysqldump from 11.2.2-MariaDB, client 10.19 for linux-systemd (x86_64)
dvaneeden@dve-carbon:~$ 

If a system has both MySQL and MariaDB we can still use mysqldump. If a system only has mariadb-dump and no mysqldump we can call the former if the latter fails to exec. We would then have to update the regexps.