time column type string formatting and test coverage #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Jun 18, 2024
mysql/util_test.go
Outdated
| } | ||
|
|
||
| for _, test := range tests { | ||
|
|
There was a problem hiding this comment.
mysql/util_test.go:42:30: unnecessary leading newline (whitespace)
from CI ⬆️
lance6716
reviewed
Jun 18, 2024
mysql/util_test.go
Outdated
| for _, test := range tests { | ||
| n := len(test.Data) | ||
|
|
||
| // binary.LittleEndian.PutUint32(data[1:], uint64(test.Seconds)) |
There was a problem hiding this comment.
we can remove this comment?
mysql/util_test.go
Outdated
| got, err := FormatBinaryTime(n, test.Data) | ||
| if test.Error { | ||
| require.Error(t, err) | ||
| } else if err != nil { |
There was a problem hiding this comment.
we can use
... else {
require.NoError(t. err)
}
here
lance6716
approved these changes
Jun 18, 2024
willdonnelly
added a commit
to estuary/connectors
that referenced
this pull request
Aug 6, 2024
This is past the latest tagged release version of `v1.8.0` because we need go-mysql-org/go-mysql#891 which fixed a bug with zero-valued `time` columns when using prepared statements. If/when a new version is tagged we can move to that, the only reason we're naming a specific commit is because it's the current HEAD of that repository.
willdonnelly
added a commit
to estuary/connectors
that referenced
this pull request
Aug 9, 2024
This is past the latest tagged release version of `v1.8.0` because we need go-mysql-org/go-mysql#891 which fixed a bug with zero-valued `time` columns when using prepared statements. If/when a new version is tagged we can move to that, the only reason we're naming a specific commit is because it's the current HEAD of that repository.
willdonnelly
added a commit
to estuary/connectors
that referenced
this pull request
Aug 19, 2024
This is past the latest tagged release version of `v1.8.0` because we need go-mysql-org/go-mysql#891 which fixed a bug with zero-valued `time` columns when using prepared statements. If/when a new version is tagged we can move to that, the only reason we're naming a specific commit is because it's the current HEAD of that repository.
willdonnelly
added a commit
to estuary/connectors
that referenced
this pull request
Aug 19, 2024
This is past the latest tagged release version of `v1.8.0` because we need go-mysql-org/go-mysql#891 which fixed a bug with zero-valued `time` columns when using prepared statements. If/when a new version is tagged we can move to that, the only reason we're naming a specific commit is because it's the current HEAD of that repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the string formatting of time type columns,
FormatBinaryTimedoes not return properly formatted time strings in all cases.In the zero value case, it was incorrectly returning a
dateformatted string instead of the expected zerotimeof00:00:00. For positive times there was a leading null byte in the returned []byte.CREATE TABLE time_test (ts TIME);INSERT INTO time_test (ts) VALUES ("00:00:00"), ("06:12:10");Reading the values out (using a statement as direct queries don't use FormatBinaryTime)
SELECT * FROM %s WHERE ts > ?with query parameter
-5or some other numberresulted in
when the expected result is