Update client pool logic #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation - add getDefaultPoolOptions
…ation - tests refactoring
lance6716
approved these changes
Jan 25, 2024
|
@lance6716 sorry, one more time :) Together we didn't notice that I accidentally committed the wrong thing to the Makefile: |
lance6716
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client/pool does not report connection problems properly: in cases of authorization errors, version incompatibility, incorrect database address, network problems, etc.
Also, we have #701 with a request for new functionality in the same case.
This PR updates the pool logic a bit: more user-friendly function
NewPoolWithOptions, and optionWithNewPoolPingTimeoutfor doing connect&ping during pool initialization.Also, this fixes
make test-localafter #803.