Skip decoding of excluded table rows #831
Merged
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Oct 12, 2023
mcuelenaere
force-pushed
the
skip-decoding-excluded-table-rows
branch
from
651feae to
c59e381
Compare
|
Hi, don't forget to change the PR state from draft to ready when you think it's OK |
|
Okay, after doing some brief testing this seems to work! I was unable to verify the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is untested atm, hence why it is a draft
This PR changes
canalto skip decodingRowsEventevents for tables that it is not interested in (cfrIncludeTableRegex,ExcludeTableRegex).The rationale for implementing this, is that we noticed that quite a bit of compute went to parsing JSON fields, even though we were not listening to any tables containing JSON fields. This PR should fix that.