fix: allow zero time

go-mysql-org · Dec 25, 2024 · d5006de · d5006de
1 parent f0ca5b7
commit d5006de
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/mysql/resultset_helper.go b/mysql/resultset_helper.go
@@ -3,7 +3,6 @@ package mysql
 import (
 	"bytes"
 	"encoding/binary"
-	"fmt"
 	"math"
 	"strconv"
 	"time"
@@ -56,7 +55,7 @@ func toBinaryDateTime(t time.Time) ([]byte, error) {
 	var buf bytes.Buffer
 
 	if t.IsZero() {
-		return nil, fmt.Errorf("zero time")
+		return nil, nil
 	}
 
 	year, month, day := t.Year(), t.Month(), t.Day()

diff --git a/mysql/util_test.go b/mysql/util_test.go
@@ -75,7 +75,6 @@ func TestToBinaryDateTime(t *testing.T) {
 			Name:   "Zero time",
 			Data:   time.Time{},
 			Expect: nil,
-			Error:  true,
 		},
 		{
 			Name:   "Date with nanoseconds",