Merge pull request #1044 from skaggmannen/master

x/mango: Fix evaluation of `$exists: false` always failing
go-kivik · Sep 11, 2024 · 4c26937 · 4c26937
2 parents 0b67452 + a797e87
commit 4c26937
Show file tree

Hide file tree

Showing 3 changed files with 89 additions and 23 deletions.
diff --git a/x/collate/collate.go b/x/collate/collate.go
@@ -73,6 +73,11 @@ func CompareObject(a, b interface{}) int {
 			return -1
 		}
 		return 1
+	case jsonTypeNull:
+		if b == nil {
+			return 0
+		}
+		return -1
 	case jsonTypeNumber:
 		return int(a.(float64) - b.(float64))
 	case jsonTypeString:

diff --git a/x/mango/match_test.go b/x/mango/match_test.go
@@ -129,35 +129,43 @@ func TestMatch(t *testing.T) {
 		want: false,
 	})
 	tests.Add("exists", test{
-		sel: &conditionNode{
-			op:   OpExists,
-			cond: true,
+		sel: &fieldNode{
+			field: "foo",
+			cond:  &conditionNode{op: OpExists, cond: true},
+		},
+		doc: map[string]interface{}{
+			"foo": "bar",
 		},
-		doc:  "foo",
 		want: true,
 	})
 	tests.Add("!exists", test{
-		sel: &conditionNode{
-			op:   OpExists,
-			cond: false,
+		sel: &fieldNode{
+			field: "baz",
+			cond:  &conditionNode{op: OpExists, cond: true},
+		},
+		doc: map[string]interface{}{
+			"foo": "bar",
 		},
-		doc:  "foo",
 		want: false,
 	})
 	tests.Add("not exists", test{
-		sel: &conditionNode{
-			op:   OpExists,
-			cond: false,
+		sel: &fieldNode{
+			field: "baz",
+			cond:  &conditionNode{op: OpExists, cond: false},
+		},
+		doc: map[string]interface{}{
+			"foo": "bar",
 		},
-		doc:  nil,
 		want: true,
 	})
 	tests.Add("!not exists", test{
-		sel: &conditionNode{
-			op:   OpExists,
-			cond: true,
+		sel: &fieldNode{
+			field: "baz",
+			cond:  &conditionNode{op: OpExists, cond: true},
+		},
+		doc: map[string]interface{}{
+			"foo": "bar",
 		},
-		doc:  nil,
 		want: false,
 	})
 	tests.Add("type, null", test{
@@ -436,6 +444,53 @@ func TestMatch(t *testing.T) {
 		doc:  "bar",
 		want: false,
 	})
+	tests.Add("field selector, nested", test{
+		sel: &fieldNode{
+			field: "foo.bar.baz",
+			cond: &conditionNode{
+				op:   OpEqual,
+				cond: "hello",
+			},
+		},
+		doc: map[string]interface{}{
+			"foo": map[string]interface{}{
+				"bar": map[string]interface{}{
+					"baz": "hello",
+				},
+			},
+		},
+		want: true,
+	})
+	tests.Add("field selector, nested, non-object", test{
+		sel: &fieldNode{
+			field: "foo.bar.baz",
+			cond: &conditionNode{
+				op:   OpEqual,
+				cond: "hello",
+			},
+		},
+		doc: map[string]interface{}{
+			"foo": "hello",
+		},
+		want: false,
+	})
+	tests.Add("!field selector, nested", test{
+		sel: &fieldNode{
+			field: "foo.bar.baz",
+			cond: &conditionNode{
+				op:   OpEqual,
+				cond: "hello",
+			},
+		},
+		doc: map[string]interface{}{
+			"foo": map[string]interface{}{
+				"bar": map[string]interface{}{
+					"buzz": "hello",
+				},
+			},
+		},
+		want: false,
+	})
 	tests.Add("elemMatch", test{
 		sel: &fieldNode{
 			field: "foo",

diff --git a/x/mango/selector.go b/x/mango/selector.go
@@ -127,14 +127,20 @@ func (f *fieldNode) String() string {
 }
 
 func (f *fieldNode) Match(doc interface{}) bool {
-	m, ok := doc.(map[string]interface{})
-	if !ok {
-		return false
-	}
-	val, ok := m[f.field]
-	if !ok {
-		return false
+	val := doc
+
+	// Traverse nested fields (e.g. "foo.bar.baz")
+	segments := strings.Split(f.field, ".")
+	for _, segment := range segments {
+		m, ok := val.(map[string]interface{})
+		if !ok {
+			return false
+		}
+
+		val = m[segment]
 	}
+
+	// Even if the field does not exist we need to pass it to the condition expression because of `$exists`
 	return f.cond.Match(val)
 }