Suggested changes to implement issues #157 and #158 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…*ForeignKey field and a SetForeignKey method. New types FKOnChangeAction and ForeignKey.
…oreign keys are not yet functioning. test_all script enhanced to allow easy testing of each or all dialects.
…Query and QueryRow methods now have public visibility so that clients can create their own wrappers should they need to. New file dbmap.go contains the DbMap methods from gorp.go that were not DDL controls.
… funcs to ignore this error and continue to return zeroVal (per docs). This fixes SelectOne() for pointers to primitive values. (cherry picked from commit f296a21)
|
I've been using your fork (with pg) and it's been excellent so far. Thanks! |
|
Hi there. Good stuff. It's a huge PR though so it's hard for me to digest it. Also, splitting up gorp.go, while probably long overdue, is something I'd want to do in a PR on its own since it makes it hard for me to merge any other pending PRs. So I'm wondering if we can split this work up into smaller PRs:
Do you have time/interest to work together on that? Thanks again. |
|
Yes, I'll replay the same changes on the current development tip and commit as two separate PRs. |
|
Is this merge going ahead? Looks like the PR hasn't gone in yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#157 Add support for foreign key constraints
#158 Make SqlExecutor publicly usable