Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split mail sender sub package from mailer service package #32618

Merged
merged 5 commits into from
Nov 30, 2024
Merged

Split mail sender sub package from mailer service package #32618

merged 5 commits into from
Nov 30, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 23, 2024 •
edited
Loading

Move all mail sender related codes into a sub package of services/mailer. Just move, no code change.
Then we just have dependencies on go-mail package in the new sub package. We can use other package to replace it because it's unmaintainable. ref #18664

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 23, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 23, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 23, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 23, 2024
@lunny lunny mentioned this pull request Nov 23, 2024
Closed
@Neustradamus
Copy link

@lunny: Nice work, thanks!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 27, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2024
@lafriks lafriks enabled auto-merge (squash) November 30, 2024 00:51
@lafriks lafriks merged commit 79d593a into go-gitea:main Nov 30, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 30, 2024
@lunny lunny deleted the lunny/move_mail_sender branch November 30, 2024 02:07
@Neustradamus
Copy link

@lunny: Good job!

Can not wait to see next steps ^^

zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
24e46aa 
* giteaofficial/main:
  Split mail sender sub package from mailer service package (go-gitea#32618)
  Fix a bug in actions artifact test (go-gitea#32672)
  Move GetFeeds to service layer (go-gitea#32526)
@lunny
Copy link
Member Author

lunny commented Nov 30, 2024

@lunny: Good job!

Can not wait to see next steps ^^

I have a new pull request as next step #32682

@lunny lunny modified the milestones: 1.24.0, 1.23.0 Nov 30, 2024
@Neustradamus Neustradamus mentioned this pull request Dec 1, 2024
Merged
@Neustradamus
Copy link

@lunny: Excellent, good job!
If all devs were like you! :)

Linked to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @Neustradamus @lafriks @wolfogre @GiteaBot