Small improvements to filesystem-deploy action #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paths used aren't consistent in the log, e.g.:
2024/12/17 15:56:10 ==== Deploy onto image ====
2024/12/17 15:56:21 Setting up fstab
2024/12/17 15:56:21 Setting up /etc/kernel/cmdline
For all log and error messages, use the full path to fstab and cmdline.
Signed-off-by: Christopher Obbard <[email protected]>
Make use of defer when closing file handles. Signed-off-by: Christopher Obbard <[email protected]>
We should be consistent and return an error to bubble up rather than logging the error. Signed-off-by: Christopher Obbard <[email protected]>
sjoerdsimons
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some tiny improvements.