Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CDP support #10

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Add CDP support #10

merged 1 commit into from
Apr 13, 2023

Conversation

dkropachev
Copy link
Contributor

@dkropachev dkropachev commented Apr 13, 2023 •
edited
Loading

@dkropachev dkropachev merged commit 181ad43 into master Apr 13, 2023
@dkropachev
Copy link
Contributor Author

dkropachev commented Apr 13, 2023 •
edited
Loading

@wanmai, @berniexie, @khaelou, @Stitch-June, since https://github.com/tebeka/selenium is dead, please consider using https://github.com/go-auxiliaries/selenium instead

dkropachev added a commit that referenced this pull request Apr 14, 2023
@dkropachev
Remove GenerateCDProtoContext to avoid unnecessary tight coupling
54233c1 
After #10 was merged it was decided to drop GenerateCDProtoContext to avoid tight coupling.
Instead it is recomended to implement GenerateCDProtoContext analogue apart using ExecuteChromeDPCommand
@dkropachev dkropachev mentioned this pull request Apr 14, 2023
Merged
@repulsio
Copy link

repulsio commented Feb 9, 2024

Thank you for this PR and whole repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkropachev @repulsio