add params to conditionally manage package, install & service

[zipkid]

Add params to conditionally manage package, install & service

[jrevillard]

Sorry for the delay. Thanks for the contribution.
Could you fix the tests please ?

[zipkid]

Ok, i will do that asap.

[vStone]

@jrevillard since zipkid his asap is a multi-year plan: I'm fixing the tests and have one failing test left:

expected Puppet::Error with message matching /Creating mrpe.cfg is unsupported for operatingsystem/ but nothing was raised

Looks like this test should actually not exist since we always have a default value for agent_config_dir (on which the code is depending for testing).

Could you confirm I can remove this test or do you want me to add more logic to test for (example) the package installation of the agent.

[jrevillard]

@vStone sorry for the delay! it seems that I have notification issues.

It seems linked to this functionality isn't it: #7 ?

[jrevillard]

Please look at this file: https://github.com/gnubila-france/puppet-check_mk/blob/master/manifests/agent/mrpe.pp

For which OS are you running the tests. If it's not Debian nor RedHat, please compete mrpe.pp if possible.

Best.