Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of this module #13

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Future of this module #13

wants to merge 13 commits into from

Conversation

zyronix
Copy link

@zyronix zyronix commented Feb 6, 2019

Hi there,

This module has not been updated for a year . Still I love it and I have been working on getting Puppet 5 & 6 support for it. As well as I have been working on support for debian 8 & 9 (as well as ubuntu), add PDK support and RHEL support (6&7).

I am wondering what your plans are for the future of this module. Are you planning to keep it? Support it? In my opinion it is quite hard to find a good module for check_mk on the forge. There are roughly 10 modules which all do something with check_mk or omd. So lets clear up to noise and deprecate those modules.

I would like to hear your opinion about this.

This Pull request is still WIP, because I could not find any contact details on the project page this is my attempt to connect with you.

This commit was used to remove all style errors.
Removed non standard files
Removed all unit test because they contained too much style errors, will
be added in later commits.
This is a breaking change
Some configuration has been removed, because it is not recommended
Also rewrote spec test for changed classes
Breaking change!
With check_mk and other OSses switching to systemd inetx is not being
used anymore
@alexjfisher
Copy link

Maybe Vox Pupuli could help?

@jrevillard
Copy link
Member

@zyronix thx for the work.
We are still using this module internally but we did not updated it for puppet 5/6 as we did not update yet.
I would be very happy to merge when you work is ready of course.

Also as @alexjfisher said, if voxpopuli want to maintain it, I'm also fine with it.

Best,
Jérôme

@zyronix
Copy link
Author

zyronix commented Mar 26, 2019

Sorry for my somewhat delayed response.
I like the idea to move this module into the voxpopuli namespace.
Most of the code is ready, however; I still have to port some of the old code. I might find some time this week to add that code to the module.
If everyone agrees to move it to vox, what would be the next step to take (after my commits)?

@alexjfisher
Copy link

@zyronix Hi! There's some outline documentation on our website.

The best plan is to either drop by the #voxpupuli Puppet Community slack channel or #voxpupuli on Freenode IRC.

@alexjfisher
Copy link

@jrevillard How would you like to proceed?

@jrevillard
Copy link
Member

@alexjfisher if you find somebody from Vox Populy to fork this repo then I will mark it deprecated and redirect to the new repo.

@zyronix
Copy link
Author

zyronix commented Apr 17, 2019

@jrevillard Alex is a member of Voxpupuli, they forked the module and awaiting some minor changes before the initial pupuli release will be done. See:

https://github.com/voxpupuli/puppet-check_mk

@jrevillard
Copy link
Member

Ok the module is now marked as deprecated. Should I put it read only or do you want me to merge this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants