-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding kyc link and connect button #792
Conversation
|
Hi @josojo , great job! Another minor case: could we navigate a user to the https://qualify.swarm.markets/ in another tab? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return ( | ||
<> | ||
<Wrapper> | ||
{auctionInfoLoading && <InlineLoading size={SpinnerSize.small} />} | ||
{!auctionInfoLoading && isPrivate && !signatureAvailable && ( | ||
{!auctionInfoLoading && isPrivate && !signatureAvailable && account == null && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may also be confusing just to show the button Connect Wallet
, how about changing the account
logic to show that part?
<PrivateWrapper>
<LockBig />
<TextBig>Private auction</TextBig>
<EmptyContentTextNoMargin>
You need to get allowed to participate.
</EmptyContentTextNoMargin>
</PrivateWrapper>
{account == null ? (
<ActionButton onClick={toggleWalletModal}>Connect Wallet</ActionButton>
) : (
<EmptyContentTextSmall>
{linkForKYC ? (
<ExternalLink href={linkForKYC}>Get Allowed ↗</ExternalLink>
) : (
<EmptyContentTextSmall>
Ask the auctioneer to get allow-listed.
</EmptyContentTextSmall>
)}{' '}
</EmptyContentTextSmall>
)}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like this one. Leet's do it
<EmptyContentTextSmall> | ||
{linkForKYC ? ( | ||
<ExternalLink href={linkForKYC}> | ||
<h2>Get Allowed ↗</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the designers don't like to have a h2
here 😂, we could get the h2 style at LinkCSS
or maybe use the same style of Connect Wallet button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should modify it. Though my css styles are very bad.
@maria-vslvn could you find a proper solution that looks somehow similar to the h2?
@elena-zh I have applied some changes, what do you think? I have tried to keep the same pattern for the other cases @maria-vslvn I'm not sure if the size is right here (Get Allowed text), and if you guys use relative units. |
This adds the kyc link that can be maintained for each auctioning token
the KYC json list should be fetched from this github repo, instead of the build, but for reviewing the PR I am pulling it via internal reference.
If the account is not yet connected, currently the interface shows that the user is not allowlisted, which is confusing. I changed that behaviour as well and show the user the connect button.
@henrypalacios any proposal for improvements are highly welcome