v0.4.0 #84
Merged
v0.4.0 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josojo
commented
Mar 11, 2021
src/deploy/deployer_easyAuction.ts
Outdated
Comment on lines
25
to
34
| const easyAuctionDeployed = await get(easyAuction); | ||
| let weth9Address; | ||
| const chainId = (await hre.ethers.provider.getNetwork()).chainId; | ||
| if (chainId == 4) { | ||
| weth9Address = weth9Networks.WETH9["4"]["address"]; | ||
| } else if (chainId == 1) { | ||
| weth9Address = weth9Networks.WETH9["1"]["address"]; | ||
| } else if (chainId == 100) { | ||
| weth9Address = "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d"; | ||
| } |
There was a problem hiding this comment.
Temporary solution only
|
Pr is not perfect, but I would like to get it merged and improve later, in order to reduce dependent PRs. |
fedgiac
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Looks good.
Even if it's not fully working yet, you can do a partial verification on xdai with:
$ npx hardhat sourcify --network xdai
verifying AllowListOffChainManaged (0x80b8AcA4689EC911F048c4E0976892cCDE14031E on chain 100) ...
{"error":"Contract name: AllowListOffChainManaged. Verifying contracts with immutable variables is not supported for xDAI Chain."}
verifying DepositAndPlaceOrder (0x69BE2732891A10D6d3d00073A834194Ff3EeB71d on chain 100) ...
{"error":"Contract name: DepositAndPlaceOrder. Verifying contracts with immutable variables is not supported for xDAI Chain."}
verifying EasyAuction (0x9BacE46438b3f3e0c06d67f5C1743826EE8e87DA on chain 100) ...
=> contract EasyAuction is now verified
So at least EasyAuction is now verified on xdai. For the rest, we need to wait for immutables to be supported by Sourcify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New deployment of new contracts with NPM release