Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2 edits #6

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

ojustino
Copy link

@ojustino ojustino commented May 9, 2024

Hi @gmzsebastian, here are some edits in response to your work in spacetelescope#175. The high-level summary:

  • Updated the docstrings for addSersicProfile() and oldSersicProfile() in stips/astro_image/astro_image.py. The previous versions didn't actually describe the arguments used to call the methods elsewhere in the code, instead listing arguments and returned objects that don't currently appear. Please let me know if you agree that my edits follow the functions' intended inputs and outputs.
  • Increased minimum version of Pandeia in installation docs to match the updates elsewhere.
  • Increased the minimum version of Python to 3.11 3.10 while also performing tests in 3.11 to match other dependencies.
  • Edited version in setup.cfg to 2.2.0 – this is what actually changes the version when you install on the command line.

Also, do you have a number for how much less accurate the fast_galaxy scenario is for injecting sources? It might be useful to quantify it since you put a number on the gain in efficiency.

@ojustino ojustino force-pushed the release-2.2-edits branch 2 times, most recently from e1169aa to 0cccdc4 Compare May 9, 2024 14:12
@ojustino ojustino force-pushed the release-2.2-edits branch from 0cccdc4 to 3b7d929 Compare May 9, 2024 14:21
@ojustino ojustino force-pushed the release-2.2-edits branch from 3b7d929 to 53263b2 Compare May 9, 2024 17:48
@gmzsebastian
Copy link
Owner

Thanks @ojustino, it all looks great. Thanks for the updates! I will accept and change a couple typos that @eunkyuh found in the docs and I will change the default on the docstring of convolve_galaxy to True, which I just noticed I had mislabeled.

@gmzsebastian gmzsebastian merged commit 8f1738b into gmzsebastian:master May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants