Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gmzsebastian, here are some edits in response to your work in spacetelescope#175. The high-level summary:
addSersicProfile()
andoldSersicProfile()
instips/astro_image/astro_image.py
. The previous versions didn't actually describe the arguments used to call the methods elsewhere in the code, instead listing arguments and returned objects that don't currently appear. Please let me know if you agree that my edits follow the functions' intended inputs and outputs.3.113.10 while also performing tests in 3.11 to match other dependencies.version
insetup.cfg
to 2.2.0 – this is what actually changes the version when you install on the command line.Also, do you have a number for how much less accurate the
fast_galaxy
scenario is for injecting sources? It might be useful to quantify it since you put a number on the gain in efficiency.