-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add json schema for config #534
base: main
Are you sure you want to change the base?
feat: Add json schema for config #534
Conversation
EmilyGraceSeville7cf
commented
Feb 6, 2024
•
edited
Loading
edited
- hints for documented properties in README.md
- links to README.md in hints
- property format validation
@EmilyGraceSeville7cf Wow, thanks for taking the time to do this 🙌 I've used JSON schemas for JSON files (eg. tsconfig, prettier etc), but have never used them for YAML before. How do I use these as an end user? Also, would you happen to know whether SchemaStore accepts YAML configs like this one? |
There are plenty of options available for u in this case:
JSON schema is suitable for validating YAML documents, if I correctly inferred what you meant. ;) |
I finished my PR. I need a review, because I have some doubts about what properties should be marked as required (it's not documented). P.S. I recommend make this schema autogenerated later in C#, but I can't help you here, I don't know this language. |
@lars-berger, can you review this PR? |
I noticed the schema has an error with |
@JustBarnt, I've fixed this problem. 😄 |