Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct y limits in ProfileViewerState when min same as max #2513

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Correct y limits in ProfileViewerState when min same as max #2513

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3490c1d
BUG: Correct y limits when min same as max
pllim Sep 11, 2024
c407b70
Update glue/viewers/profile/state.py
pllim Sep 23, 2024
321d609
Update state.py
pllim Sep 23, 2024
a4a87f8
Update glue/viewers/profile/state.py
pllim Sep 23, 2024
ff50e22
Add tests
pllim Sep 23, 2024
840cbeb
Remove whitespace
pllim Sep 23, 2024
a2f2710
OMG math
pllim Sep 23, 2024
10e04ad
Parametrize tests
dhomeier Sep 23, 2024
acffd4d
Merge pull request #1 from dhomeier/pllim-fix-yminmax-same
pllim Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions glue/viewers/profile/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@
if y_max > y_min:
self.y_min = y_min
self.y_max = y_max
elif np.allclose(y_min, y_max):
dy = max(0.1, 0.1 * y_min)
self.y_min = y_min - dy
self.y_max = y_max + dy

Check warning on line 236 in glue/viewers/profile/state.py

View check run for this annotation

Codecov / codecov/patch

glue/viewers/profile/state.py#L234-L236 

Added lines #L234 - L236 were not covered by tests
pllim marked this conversation as resolved.
Show resolved Hide resolved
else:
self.y_min = 0
self.y_max = 1
Expand Down