Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Qt-related code (and glue.qglue) #2477

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Feb 27, 2024

This removes all deprecated Qt-related code. Packages to check:

  • glue-qt
  • glue-vispy-viewers
  • glue-wwt
  • glue-plotly
  • glue-jupyter
  • glue-astronomy
  • jdaviz

@astrofrog astrofrog force-pushed the remove-deprecated-qt branch from c6bbfee to 5217e3c Compare February 27, 2024 14:08
@astrofrog astrofrog marked this pull request as ready for review February 27, 2024 14:55
@astrofrog
Copy link
Member Author

@jfoster17 @Carifio24 @dhomeier @CyclingNinja - just FYI I will be merging this in shortly, let me know if you spot any issues in dependencies!

@dhomeier
Copy link
Collaborator

dhomeier commented Feb 27, 2024

glue-astronomy has 2 uses of qglue in the spectral_cube code was using this, but only as a fallback for older glue versions I think; can try a CI re-run of glue-viz/glue-astronomy#98 once you've merged.

@astrofrog astrofrog merged commit 1bbd6e8 into glue-viz:main Feb 28, 2024
24 checks passed
@dhomeier dhomeier changed the title Remove deprecated Qt-related code Remove deprecated Qt-related code (and glue.qglue) Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants