-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-recursive composite subsets #2140
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 87.99% 87.86% -0.13%
==========================================
Files 245 246 +1
Lines 22322 22685 +363
==========================================
+ Hits 19642 19932 +290
- Misses 2680 2753 +73
Continue to review full report at Codecov.
|
I'll try reviewing this soon, but in the mean time, could you fix the code style issues and also add a regression test that would normally have failed due to a recursion error? |
Fix for #1348. This PR adds a helper function that allows traversing the state tree in composite subset states without making recursive function calls.