Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against older glue versions and update bqplot tests #55

Merged
merged 5 commits into from
Jan 1, 2024

Conversation

Carifio24
Copy link
Member

This PR makes a few updates to the test suite:

  • Rename test_data to make_data in the tests for the bqplot exporters, so that pytest doesn't think that it's a test
  • Add glue### testing environments to test glue-plotly against older minor versions of glue. Since our current pin is to glue-core>=1.13.1, there's no need to go back further than 1.13.*. This resolves Test against older glue versions #54. The solution here isn't the most elegant, but I'm not sure of another way to do this.
  • Remove tests for Python < 3.8, since glue requires Python >= 3.8.

@Carifio24
Copy link
Member Author

Carifio24 commented Dec 31, 2023

Hmm, this worked for me locally, but from the output of pip freeze in the CI we aren't pulling in the old versions of glue in these environments. Will investigate further.

@Carifio24 Carifio24 merged commit 8707c32 into glue-viz:main Jan 1, 2024
33 checks passed
@Carifio24 Carifio24 added CI no-changelog-entry-needed Skipped in automatic changelog generation labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI no-changelog-entry-needed Skipped in automatic changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test against older glue versions
1 participant