-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle GWCS for specutils 2.0 compatibility #100
base: main
Are you sure you want to change the base?
Conversation
…ution doesn't vary spatially
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 96.68% 86.73% -9.96%
==========================================
Files 18 16 -2
Lines 1448 1470 +22
==========================================
- Hits 1400 1275 -125
- Misses 48 195 +147 ☔ View full report in Codecov by Sentry. |
setup.cfg
Outdated
@@ -20,7 +20,7 @@ install_requires = | |||
astropy>=4.0 | |||
glue-core>=1.6.1 | |||
regions>=0.4 | |||
specutils>=0.7 | |||
specutils>=2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pin causes this branch refusing to install because specutils is still at 2.0.dev
that is technically less than 2.0 stable.
Co-authored-by: P. L. Lim <[email protected]>
f416dad
to
fe332dd
Compare
Adding better handling of GWCS in the Spectrum1D handler. Opening as draft since this may need a couple other changes/additions, and because it shouldn't be merged until specutils 2.0 is ready for release. I'll also add some test coverage for the new code.