Fix computation of joins inside nested objects #15123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconard96
force-pushed
the
fix/joins_nested_objs
branch
from
189f80b to
e85574c
Compare
|
Replaced by #15788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on pluginsGLPI/fields#670 I found that joins were not working for the custom fields.
Until now, joins where only needed for top-level properties like the
locationproperty. The nested properties likelocation.idwere always scalar properties.For the fields plugin, the complex nature of the DB schema where each field is in its own table, the joins were nested. There is a
custom_fieldsobject property and then for each field, there is a child object which has the join info.This is still a draft until I fix remaining issues with the fields plugin integration.