Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Use hatch as build system #1392

Merged
merged 9 commits into from
Nov 11, 2023
Merged

👷 Use hatch as build system #1392

merged 9 commits into from
Nov 11, 2023

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 10, 2023

This PR changes the build system backend from the old setuptools way of doing things to hatch.
I also changed the docs from RST to MD and removed the quick start so the docs build again.
And the release step to use trusted-publishers since that was already set up on the PyPI side by @jsnel and is kinda related to building 😅

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 📚 Adds documentation of the feature

@s-weigand s-weigand requested review from a team as code owners November 10, 2023 13:00
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/hatch

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s-weigand
Copy link
Member Author

Site note about actionlint it looks up the optional dependencies shellcheck and pyinstaller outside of the pre-commit venv, so local results and CI results may vary.
But since I'm the most likely person to touch workflows that should be fine 😅

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lots of changes, but mostly restructuring of contents.

@s-weigand s-weigand merged commit 9d5d44e into glotaran:staging Nov 11, 2023
18 of 31 checks passed
@s-weigand s-weigand deleted the hatch branch November 11, 2023 15:12
jsnel pushed a commit to jsnel/pyglotaran that referenced this pull request Jun 2, 2024
* 👷 Use hatch as build system

* 🧰 Use pyproject-fmt

* 👷📚 Use markdown instead of rst for docs

Files were converted with rst-to-myst

* 🧹 Fix sphinx deprecations

* 📚 Add information on how to install pre-commit

* 🩹 Move IPython for docs dependencies to test dependecies

* 🩹 Update codeowners config

* 🧰 Use actionlint

* 🩹 Fix shellcheck issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants