Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EM dash (—, unicode x2014) instead of double hyphen (--) … #1019

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

x-englishwordnet
Copy link

…to offset parenthetical text and normalize spacing around it

The scope is definitions + examples.

The contexts have been reviewed but no undue use of parenthetical text was noted — the semantics seems good and I'll stick with Princeton's work.

So the substitution is 'automatic', but for the spaces around '--' which have been normalized (in most cases, but not all, there was no space).

This PR follows Merriam Webster's guidelines.

This change is easily reversible for legacy work that uses '--' and does not complicate processing.

…t parenthetical text, normalize spacing around it
@arademaker
Copy link
Member

I like the change. It makes sense.

@jmccrae jmccrae merged commit f3ff1fa into globalwordnet:main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants