Refactor: FSP reconciliation module #6382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 26 out of 41 changed files in this pull request and generated no comments.
Files not reviewed (15)
- services/121-service/src/financial-service-provider-callback-job-processors/financial-service-provider-callback-job-processors.module.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/intersolve-voucher/services/intersolve-voucher-cron.service.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/safaricom/safaricom.service.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/safaricom/safaricom.service.spec.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/commercial-bank-ethiopia/commercial-bank-ethiopia.service.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/intersolve-visa/intersolve-visa.service.ts: Evaluated as low risk
- services/121-service/src/financial-service-provider-callback-job-processors/processors/safaricom-transfer-callback-job.processor.ts: Evaluated as low risk
- services/121-service/src/financial-service-provider-callback-job-processors/processors/safaricom-timeout-callback-job.processor.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/intersolve-visa/intersolve-visa.module.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/commercial-bank-ethiopia/commercial-bank-ethiopia.controller.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/intersolve-voucher/intersolve-voucher.service.ts: Evaluated as low risk
- services/121-service/src/payments/payments.controller.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/domains/payment/payment.api.service.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/intersolve-voucher/intersolve-voucher.controller.ts: Evaluated as low risk
- services/121-service/src/payments/fsp-integration/excel/excel.service.ts: Evaluated as low risk
RubenGeo
force-pushed
the
feat.reconciliation
branch
from
f555683 to
2000de9
Compare
Signed-off-by: Ruben <[email protected]>
RubenGeo
force-pushed
the
feat.reconciliation
branch
from
2000de9 to
4aa6fbd
Compare
Signed-off-by: Ruben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#32623
Describe your changes
Checklist before requesting a review
Portalicious preview deployment
https://lively-river-04adce503-6382.westeurope.5.azurestaticapps.net