Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cherry picked test and dependencies #6374

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add cherry picked test and dependencies #6374

wants to merge 5 commits into from

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Jan 9, 2025 •
edited
Loading

AB#32422

Describe your changes

Adds test for checking correct display of payment statuses in the "Transfers data" graph.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6374.westeurope.5.azurestaticapps.net

@Piotrk39 Piotrk39 mentioned this pull request Jan 9, 2025
Closed
4 tasks
@Piotrk39 Piotrk39 added chore Something that does not affect the end user portalicious Changes related to the portalicious release labels Jan 9, 2025
@Piotrk39 Piotrk39 marked this pull request as ready for review January 15, 2025 16:12
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-graph-in-view-payment branch from 5bc892f to d61aaf3 Compare January 15, 2025 16:16
@Piotrk39 Piotrk39 requested a review from arsforza January 15, 2025 16:17
Piotrk39 and others added 4 commits January 23, 2025 21:03
@Piotrk39
Add cherry picked test and dependencies
bdf03de
@Piotrk39
Add error handling
3aac667
@Piotrk39
fix Seed script import
97cae65
@arsforza @Piotrk39
portalicious: fix payment graph + test (#6396)
55d18be 
* fix: refetch based on PaymentAggregate count

* fix: rm page reload form test

* fix: add await to test

* fix: change expected amount
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-graph-in-view-payment branch from 3716cb3 to 55d18be Compare January 23, 2025 20:03
@Piotrk39
Copy link
Contributor Author

@arsforza Looks good to me. I moved only the fixed await inside the assertion and reduced it to 1 second after the chip is hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni requested changes

@arsforza arsforza Awaiting requested review from arsforza

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
chore Something that does not affect the end user portalicious Changes related to the portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Piotrk39 @aberonni @elwinschmitz @arsforza