Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steps: add new component #986

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Steps: add new component #986

merged 4 commits into from
Nov 6, 2023

Conversation

michac789
Copy link
Contributor

No description provided.

@michac789 michac789 added the New Component New component request label Nov 2, 2023
@michac789 michac789 self-assigned this Nov 2, 2023
@michac789 michac789 requested a review from chiahou as a code owner November 2, 2023 07:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited
Loading

Storybook Preview: https://615abff875b8f5004aa277ac-uiufuiselz.chromatic.com/

chiahou
chiahou reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@chiahou chiahou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michac789 Just realized that I made a mistake in design specs. The dot type shouldn't be the mobile design for normal type. They have different usages. I've already rectified the specs. Apologies for my oversight and thanks for building the dot version. We're going to need it very soon.

chiahou
chiahou reviewed Nov 2, 2023
View reviewed changes
src/@next/Steps/Step.tsx Outdated Show resolved Hide resolved
chiahou
chiahou reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@chiahou chiahou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see cursor turn into edit state when I mouse over a text. Can you help to check if cursor is set to 'pointer' when they are clickable, and set to 'default' when not

@michac789 michac789 requested a review from chiahou November 2, 2023 18:27
ninariccimarie
ninariccimarie reviewed Nov 3, 2023
View reviewed changes
src/@next/Steps/Step.tsx Outdated Show resolved Hide resolved
src/@next/Steps/Step.tsx Outdated Show resolved Hide resolved
src/@next/Steps/Step.tsx Outdated Show resolved Hide resolved
src/@next/Steps/StepStyle.ts Outdated Show resolved Hide resolved
src/@next/Steps/Step.tsx Outdated Show resolved Hide resolved
src/@next/Steps/StepStyle.ts Outdated Show resolved Hide resolved
src/@next/Steps/Steps.tsx Outdated Show resolved Hide resolved
src/@next/Steps/Steps.tsx Outdated Show resolved Hide resolved
src/@next/Steps/Steps.tsx Outdated Show resolved Hide resolved
@michac789 michac789 force-pushed the feature/steps-component branch from 9062b97 to b531917 Compare November 6, 2023 03:23
@ninariccimarie
Copy link
Contributor

LGTM thanks

@michac789 michac789 merged commit d4aea05 into v4 Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiahou chiahou chiahou approved these changes

@ninariccimarie ninariccimarie ninariccimarie approved these changes

Assignees

@michac789 michac789

Labels
New Component New component request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michac789 @ninariccimarie @chiahou