Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Shortcuts Icons #94

Merged
merged 12 commits into from
Feb 14, 2022
Merged

feat: Add Shortcuts Icons #94

merged 12 commits into from
Feb 14, 2022

Conversation

joshuajames-smith
Copy link
Contributor

Description

Adding shift-key, backspace-keyz enter-key, up-arrow, down-arrow, left-arrow, right-arrow, help-center + keyboard-shortcut icon .svg files to style/src/assets/icons. Then add all icons to icon.ts.

closes #86
relates gliff-ai/roadmap#79

Documentation

@philhallbio will need to create a shortcuts article in the user documentation, and require these icons – but these will not need added until the whole master issue (gliff-ai/roadmap#79) is complete. Do we need a shortcuts user documentation article for now the platform CURRENTLY stands?

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@joshuajames-smith joshuajames-smith added the feature [Improvement] New feature request. label Feb 11, 2022
@joshuajames-smith joshuajames-smith self-assigned this Feb 11, 2022
@joshuajames-smith
Copy link
Contributor Author

^ ignore! github decided to fail loading the icon and clicking Try Again made two commits, but there is only one file... 🥴

@joshuajames-smith joshuajames-smith marked this pull request as ready for review February 11, 2022 14:24
@joshuajames-smith joshuajames-smith requested review from a team, ChrisBaidoo, Kinukeo and cooper667 and removed request for a team February 11, 2022 14:24
@mergify mergify bot merged commit 925976a into main Feb 14, 2022
@mergify mergify bot deleted the addShortcutIcons branch February 14, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Improvement] New feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Shortcuts Icons
3 participants