-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Shortcuts
Icons
#94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
^ ignore! github decided to fail loading the icon and clicking |
joshuajames-smith
requested review from
a team,
ChrisBaidoo,
Kinukeo and
cooper667
and removed request for
a team
February 11, 2022 14:24
cooper667
approved these changes
Feb 11, 2022
ChrisBaidoo
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
shift-key
,backspace-key
zenter-key
,up-arrow
,down-arrow
,left-arrow
,right-arrow
,help-center
+keyboard-shortcut
icon .svg files to style/src/assets/icons. Then add all icons to icon.ts.closes #86
relates gliff-ai/roadmap#79
Documentation
@philhallbio will need to create a shortcuts article in the user documentation, and require these icons – but these will not need added until the whole master issue (gliff-ai/roadmap#79) is complete. Do we need a shortcuts user documentation article for now the platform CURRENTLY stands?
Checklist:
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!