Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Pin icon #177

Merged
merged 7 commits into from
May 4, 2022
Merged

feat: add Pin icon #177

merged 7 commits into from
May 4, 2022

Conversation

joshuajames-smith
Copy link
Contributor

@joshuajames-smith joshuajames-smith commented May 2, 2022 •
edited
Loading

Description

Adds a new pin icon.
Includes an .svg file and example to icon.ts file.

relates to gliff-ai/annotate#709

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@joshuajames-smith joshuajames-smith added the feature [Improvement] New feature request. label May 2, 2022
@joshuajames-smith joshuajames-smith self-assigned this May 2, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
1 similar comment
@github-actions

This comment was marked as outdated.

Sign in to view
@joshuajames-smith joshuajames-smith marked this pull request as ready for review May 2, 2022 15:26
@github-actions
Copy link

github-actions bot commented May 2, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-177.westeurope.azurestaticapps.net

cooper667
cooper667 suggested changes May 3, 2022
View reviewed changes
src/icons.ts Outdated Show resolved Hide resolved
@github-actions

This comment was marked as outdated.

Sign in to view
1 similar comment
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link

github-actions bot commented May 3, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-177.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 4, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-177.westeurope.azurestaticapps.net

@mergify mergify bot merged commit 5df4bde into main May 4, 2022
@mergify mergify bot deleted the addPinIcon branch May 4, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChasNelson1990 ChasNelson1990 ChasNelson1990 approved these changes

@cooper667 cooper667 cooper667 approved these changes

@ChrisBaidoo ChrisBaidoo Awaiting requested review from ChrisBaidoo

Assignees
No one assigned
Labels
feature [Improvement] New feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshuajames-smith @cooper667 @ChasNelson1990 @ChrisBaidoo