Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Pin the Labels Dialogue #709

Open
joshuajames-smith opened this issue Apr 14, 2022 · 2 comments
Open

Add Ability to Pin the Labels Dialogue #709

joshuajames-smith opened this issue Apr 14, 2022 · 2 comments
Labels
enhancement [Improvement] Enhancement request.

Comments

@joshuajames-smith
Copy link
Contributor

Problem

The current UX of the Labels dialogue within ANNOTATE means once a user clicks away it closed - this was to preserve visual retail space allowing for a clear focus on the image. This however may mean that some users have to keep clicking to open the Labels dialogue, making for a more annoying UX.

Solution

Add the ability to pin the dialogue which then stays open. This was originally designed but never implemented. The original solution was to have a pin icon where the close icon now exists within the popper dialogue. This is a toggle button, which when on means the user can click away without the dialogue closing.

Considered Alternatives

N/A

@joshuajames-smith joshuajames-smith added the enhancement [Improvement] Enhancement request. label Apr 14, 2022
@joshuajames-smith
Copy link
Contributor Author

joshuajames-smith commented May 2, 2022

We now have 2 types of containers: pin and close.

  1. pin allows the user to force a popover to remain open when they click away - normally this action cause the popover to close.
  2. close allows the user to force a dialogue to close when they click - normally if they click away this should do nothing, i.e. this should not close the dialogue.

There is 4 selector states for the pin popover: default, hover:default, active and hover:active.

  1. default defines the pin icon as black.
  2. hover:default defines the cursor property as pointer with the tooltip 'Pin Open'.
  3. active defines the pin icon as black with a white circle - this is constant`.
  4. hover:active defines the cursor property as pinter with a tooltip 'Turn Off Pin'.

There is 2 selector states for the close dialogue: default and hover.

  1. default defines the close icon as black.
  2. hover define the cursor property as pointer with the tooltip 'Close'.3.

ANNOTATE – dialogues  pin  – states

@joshuajames-smith
Copy link
Contributor Author

joshuajames-smith commented May 2, 2022

There is 4 pin popover components located within ANNOTATE.

  • Annotation Labels
  • Plugins
  • Image Channels
  • Keyboard Shortcuts (awaiting implementation > Update Shortcuts #653)

ANNOTATE – dialogues – 1

ANNOTATE – dialogues – 2

ANNOTATE – dialogues – 3

ANNOTATE – dialogues – 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [Improvement] Enhancement request.
Projects
None yet
Development

No branches or pull requests

3 participants